Welcome to ShenZhenJia Knowledge Sharing Community for programmer and developer-Open, Learning and Share
menu search
person
Welcome To Ask or Share your Answers For Others

Categories

I have a product, user and product_click model. In product_click, I have column count where I'm keeping a record, which user click which product how many times.

I have also tried

Product.sort_by{ |r|  r.product_clicks.where(user_id: user.id).first.try(:count).to_i

which giving desire result but creating lots of query on running.

product_click.rb

belongs_to :product
  belongs_to :user

product.rb

has_many :product_clicks, dependent: :destroy

user.rb

has_many :product_clicks, dependent: :destroy

Schema

create_table "product_clicks", force: :cascade do |t|
    t.bigint "product_id"
    t.bigint "user_id"
    t.bigint "count", default: 0
    t.datetime "created_at", null: false
    t.datetime "updated_at", null: false
  end

In controller

Product.left_outer_joins(:product_clicks).order("count DESC NULLS LAST")

Now i am looking something like this to work.

But here i can't able to check whether the count was of which particular user. If i'm adding

Product.left_outer_joins(:product_clicks).where(resource_clicks: { user_id: user.id }).order("count DESC NULLS LAST")

Then it showing a product which user clicked but not the 'nil' ones(which i never clicked).

I also tried this

Product.left_outer_joins(:product_clicks).where(product_clicks: { user_id: [user.id, nil] }).order("count DESC NULLS LAST")

but giving me all i clicked and all which no one else clicked. If someone click which i didn't then it not displaying to me.

See Question&Answers more detail:os

与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
thumb_up_alt 0 like thumb_down_alt 0 dislike
219 views
Welcome To Ask or Share your Answers For Others

1 Answer

While I am thinking of other ways, one straight way would be a 2 step solution.

product_ids = ProductClick.where(user_id: user.id).order('count desc').pluck(:product_id)

products = Product.where(id: product_ids)

It'll definitely improve your time and is better than your query (which is N+1).

Using preloading

Product.includes(:product_clicks).where('product_clicks.user_id' => user.id).order('product_clicks.count desc')

The above query should also result in the same way, however, it may internally hit 2 queries anyway.

Using having clause - Recommended

Product.includes(:product_clicks).having('product_clicks.user_id' => user.id).order('product_clicks.count desc')

Update - Using OR

Product.includes(:product_clicks).where('product_clicks.user_id' => user.id)
       .order('product_clicks.count desc')
       .or(
        Product.includes(:product_clicks)
               .where('product_clicks.user_id' => user.id)
               .where(product_clicks: { id: nil })
       )

与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
thumb_up_alt 0 like thumb_down_alt 0 dislike
Welcome to ShenZhenJia Knowledge Sharing Community for programmer and developer-Open, Learning and Share

548k questions

547k answers

4 comments

86.3k users

...