javascript - Groovy script code to append xml node taking 15+ hours for 6K employee records

Question

Below code is working but taking 15+ hours to execute 6000 employee records, any improvements possible?

I have two employee record structures (employee data and employee benefits) for each of 6000 employees I have merged them into single xml using personnel number (to check the xml structure please check my previous question - https://stackoverflow.com/questions/65174244/multiple-different-xml-structures-to-one-using-xml-using-xsl).

Now I have to append a node/subnode in xml employee record when ID (personIdExternal in multimap:Message1 finds same ID / PERNR in multimap:Message2.

 xml.'**'.findAll{it.name() == 'EmpEmployment'}.each{ p->

 def perID = xml.'**'.find{it.personIdExternal.text() == p.personIdExternal.text()} 
 def pernr = xml.'**'.find{it.PERNR.text() == '000'+perID.personIdExternal.text()}
 if(pernr != null)
 {    
       perID.appendNode {
       erpBenEligibility(pernr.PARDT.text()) }
  }

}  
 message.setBody(groovy.xml.XmlUtil.serialize(xml))

Sample XML:

<?xml version='1.0' encoding='UTF-8'?>
<multimap:Messages xmlns:multimap="http://sap.com/xi/XI/SplitAndMerge">
<multimap:Message1>
<person>
 <person>
    <street>test_stree1</street>
    <city>test_city1</city>
    <state>test_state1</state>
    <EmpEmployment>
     <personIdExternal> 001 </personIdExternal>
    </EmpEmployment>
 </person>
 <person>
    <street>test_stree2</street>
    <city>test_city2</city>
    <state>test_state2</state>
     <EmpEmployment>
     <personIdExternal> 002 </personIdExternal>
    </EmpEmployment>
 </person>
 <person>
    <street>test_stree3</street>
    <city>test_city3</city>
    <state>test_state3</state>
     <EmpEmployment>
     <personIdExternal> 003</personIdExternal>
     </EmpEmployment>
 </person>
</person>
</multimap:Message1>
<multimap:Message2>
<rfc:ZHR_GET_EMP_BENEFIT_DETAILS.Response xmlns:rfc="urn:sap- 
    com:document:sap:rfc:functions"> 
 <phone>
  <home>
   <phone>number1</phone>
  </home> 
  <PERNR> 001 </PERNR>
  <PARDT>#### 1 ####</PARDT>
  <home>
   <phone>number2</phone>
  </home> 
  <PERNR> 002 </PERNR>
  <PARDT>#### 2 ####</PARDT>
  <home>
   <phone>number3</phone>
  </home> 
  <PERNR> 003 </PERNR>
  <PARDT>#### 3 ####</PARDT>
</phone> 
</rfc:ZHR_GET_EMP_BENEFIT_DETAILS.Response xmlns:rfc="urn:sap-com:document:sap:rfc:functions">    
</multimap:Message2>
</multimap:Messages>

Answer 1

some major issues in your code:

• using .** accessors. if you have 10000 persons in message1, then xml.** will return an array with count(person)+count(EmpEmployment)+count(personIdExternal) = 10000*3 elements. and calling findAll on this array should scan all those elements
• inside the main loop xml.'**'.findAll{it.name() == 'EmpEmployment'}.each{ you are building nested large arrays for no reason. for example after this expression def perID = xml.'**'.find{it.personIdExternal.text() == p.personIdExternal.text()} you have perID equals to p

your code still does not correspond to the xml sample.

so, i'm going to make some assumptions to show how you could build gpath without .**.:

let we have xml like this:

<?xml version='1.0' encoding='UTF-8'?>
<multimap:Messages xmlns:multimap="http://sap.com/xi/XI/SplitAndMerge">
<multimap:Message1>
  <person>
      <person>
        <EmpEmployment>
          <personIdExternal>001</personIdExternal>
        </EmpEmployment>
      </person>
  </person>
</multimap:Message1>
<multimap:Message2>
  <phone>
      <xyz>
        <PERNR>000001</PERNR>
        <PARDT>#### 1 ####</PARDT>
      </xyz>
  </phone>
</multimap:Message2>
</multimap:Messages>

this is a code part to build large xml message:

def count = 60000 //just for test let's create xml with 60K elements
def msg = '''<?xml version='1.0' encoding='UTF-8'?>
<multimap:Messages xmlns:multimap="http://sap.com/xi/XI/SplitAndMerge">
<multimap:Message1>
  <person>
'''+
(1..count).collect{"""
      <person>
        <EmpEmployment>
          <personIdExternal>${String.format('%03d',it)}</personIdExternal>
        </EmpEmployment>
      </person>
"""}.join()+
'''  </person>
</multimap:Message1>
<multimap:Message2>
  <phone>
'''+
(1..count).collect{"""
      <xyz>
        <PERNR>${String.format('%06d',it)}</PERNR>
        <PARDT>#### ${it} ####</PARDT>
      </xyz>
"""}.join()+
'''  </phone>
</multimap:Message2>
</multimap:Messages>
'''

and now the modified transforming algorithm:

def xml = new XmlParser().parseText(msg)

def t = System.currentTimeMillis()
def ns = new groovy.xml.Namespace('http://sap.com/xi/XI/SplitAndMerge')

//for fast search let map PERNR value to a node that contains it
def pernrMap=xml[ns.Message2][0].phone[0].children().collectEntries{ [it.PERNR.text(), it] }

//itearte msg1 -> find entry in pernrMap -> add node
xml[ns.Message1][0].person[0].person.each{p->
    def emp = p.EmpEmployment[0]
    def pernr = pernrMap['000'+emp.personIdExternal.text()]
    if(pernr) emp.appendNode('erpBenEligibility', null, pernr.PARDT.text() )
}
groovy.xml.XmlUtil.serialize(xml)
println "t = ${(System.currentTimeMillis()-t)/1000} sec"

even for 60k elements in msg1 & msg2 it does transformation in less then 1 sec.